Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix early hits stealing fall kills #944

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix early hits stealing fall kills #944

merged 1 commit into from
Nov 30, 2021

Conversation

Pablete1234
Copy link
Member

Currently in PGM a fall may never be overriden by a new fall, unless it's completely finished.

With this change, a fall would be allowed to be overriden in certain situations, such as if the player touched the ground at least once or if they didn't left the ground (yet) (maybe they were under a roof).

Testing confirms this works much better than currently, where essentially the first to hit someone would get the fall kill almost always, even if it's someone else who actually punches them off (a couple seconds later).

PS: the formatting in the comment is a bit odd, but it's what the formatter enforces

@Pablete1234 Pablete1234 added the bug Something isn't working label Nov 30, 2021
@Electroid Electroid merged commit 9405327 into dev Nov 30, 2021
@Electroid Electroid deleted the fall-death-fix branch November 30, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants